On Sun, Feb 18, 2018 at 2:52 PM, David Rowley <david.row...@2ndquadrant.com> wrote: > On 17 February 2018 at 10:46, Andrew Dunstan > <andrew.duns...@2ndquadrant.com> wrote: >> The attached version largely fixes with the performance degradation >> that Tomas Vondra reported, replacing an O(N^2) piece of code in >> slot_getmissingattrs() by one that is O(N). > > I've looked over this patch and had a play around with it. > > Just a couple of things that I noticed while reading: >
[ various typos ] > > I'll try to spend some time reviewing the code in detail soon. > Thanks. I'll fix the typos in the next version of the patch, hopefully after your review. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
