On Mon, Jan 29, 2018 at 7:15 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Jan 29, 2018 at 04:34:48PM +0000, Simon Riggs wrote: >> In terms of timing of commits, I have marked the patch Ready For >> Committer. To me that signifies that it is ready for review by a >> Committer prior to commit. > > My understanding of this meaning is different than yours. It should not > be the author's role to mark his own patch as ready for committer, but > the role of one or more people who have reviewed in-depth the proposed > patch and feature concepts. If you can get a committer-level individual > to review your patch, then good for you. But review basics need to > happen first. And based on my rough lookup of this thread this has not > happened yet. Other people on this thread are pointing out that as > well.
+1 to all of that. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
