Robert Haas <robertmh...@gmail.com> writes:
> On Fri, Jan 5, 2018 at 2:38 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> * I think the Asserts in ConditionVariablePrepareToSleep and
>> ConditionVariableSleep ought to be replaced by full-fledged test and
>> elog(ERROR), so that they are enforced even in non-assert builds.
>> I don't have a lot of confidence that corner cases that could violate
>> those usage restrictions would get caught during developer testing.
>> Nor do I see an argument that we can't afford the cycles to check.
> I think those usage restrictions are pretty basic, and I think this
> might be used in some places where performance does matter. So -1
> from me for this change.
Really? We're about to do a process sleep, and we can't afford a single
test and branch to make sure we're doing it sanely?
>> * A lot of the comments could be improved, IMHO.
> No opinion without seeing what you propose to change.
OK, will put out a proposal.
regards, tom lane
