On Thu, Dec 7, 2017 at 3:14 AM, David Rowley <david.row...@2ndquadrant.com> wrote: > I just noticed a comment which has been made a little outdated by the > partition-wise join code from commit f49842d1. The comment claims that > inheritance children don't add to the effort required in join > planning, while that still may be true, we should probably mention > that partitioned tables may be a more complex case. > > The attached is my attempt at putting this right.
I don't feel entirely right about the way this seems to treat inheritance and partitioning as two entirely separate features; that's true from a user perspective, more or less, but not internally to the code. Of course, this also begs the question of whether we ought to be changing the formula somehow. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company