> On 28 Nov 2017, at 02:07, Michael Paquier <michael.paqu...@gmail.com> wrote: > > On Tue, Nov 28, 2017 at 12:11 AM, Daniel Gustafsson <dan...@yesql.se> wrote: >>> The patch needs a rebase, and there are a couple of places that need >>> an extra lookup I think: >>> $ git grep defname -- *.c | grep strcasecmp | wc -l >>> 39 >> >> Rebased and handled a few more places which I had either missed in the last >> round, or that had been added in the meantime. “PARALLEL” in aggregatecmds.c >> is intentionally using pg_strcasecmp() due to the old-style syntax which is >> still supported. > > This meritates a comment. Code readers may get confused.
Good point, added. I also sent a separate doc patch for this to -docs the
other day.
>> AFAICS this covers all relevant codepaths from the 39 above.
>
> I was just looking at the tsearch code which uses pg_strcmpcase, and
> those are defined with makeDefElem() so you should switch to strcmp in
> this case as well, no? If I patch the code myself I would get an error
> when double-quoting, making those command more consistent with the
> rest of what you are patching here:
> create extension unaccent;
> alter text search dictionary unaccent (Rules = 'unaccent'); -- ok
> alter text search dictionary unaccent (RuLes = 'unaccent'); -- ok
> alter text search dictionary unaccent ("Rules" = 'unaccent'); — error
For reasons unknown to me I had avoided poking in contrib/. Attached patch
handles the additional defname comparisons in contrib that are applicable.
The remainder of the pg_strcasecmp() calls in the text search code are
operating on a defelem list created in deserialize_deflist() rather than in the
parser, so I opted for keeping that as is rather than casefolding in the list
generation.
cheers ./daniel
defname_strcmp-v3.patch
Description: Binary data
