Noah Misch <n...@leadboat.com> writes:
> On Thu, Aug 17, 2017 at 12:15:58PM -0400, Tom Lane wrote:
>> ... it's now looking to me like we should do the above with X = 5.13.4.
>> That won't be a perfect solution, but it's about the best we can
>> readily do. Realistically, nobody out in the wider world is likely
>> to care about building current PG releases against such old Perl
>> versions on Windows; if we satisfy our older buildfarm critters,
>> it's enough for me.
> MinGW default behavior matches "cl -D_USE_32BIT_TIME_T", and MSVC >= 2005
> default behavior matches "gcc -D__MINGW_USE_VC2005_COMPAT"[1]. MinGW-built
> Perl[2] does not mention _USE_32BIT_TIME_T in $Config{ccflags}, so we
> typically must add _USE_32BIT_TIME_T when using MSVC to build 32-bit against
> MinGW-built Perl. I'm considering two ways to achieve this:
I don't really have an opinion about the relative merits of these changes,
but why do anything? The existing solution has the buildfarm happy, and
we've not heard any field complaints that I saw. I'm not sure we should
spend more time on supporting obsolete toolchain combinations that aren't
represented in the buildfarm.
regards, tom lane
