(2017/11/27 7:56), Tom Lane wrote:
Etsuro Fujita<fujita.ets...@lab.ntt.co.jp> writes:
[ fix-rewrite-tlist-v4.patch ]
I started reviewing this patch.
Great!
I did not much like the fact that it
effectively moved rewriteTargetListUD to a different file and renamed it.
That seems like unnecessary code churn, plus it breaks the analogy with
rewriteTargetListIU, plus it will make back-patching harder (since that
code isn't exactly the same in back branches). I see little reason why
we can't leave it where it is and just make it non-static. It's not like
there's no other parts of the rewriter that the planner calls.
Agreed.
Best regards,
Etsuro Fujita
