Who areb Get Outlook for Android<https://aka.ms/ghei36>
________________________________ From: Thomas Munro <thomas.mu...@gmail.com> Sent: Tuesday, February 19, 2019 5:31:26 AM To: James Sewell Cc: Andres Freund; Ravi Krishna; pgsql-generallists.postgresql.org Subject: Re: WSL (windows subsystem on linux) users will need to turn fsync off as of 11.2 On Tue, Feb 19, 2019 at 5:16 PM James Sewell <james.sew...@jirotech.com> wrote: >> Here's a starter patch that shows one of the approaches discussed. It >> gets WSL users to a better place than they were before, by suppressing >> further warnings after the first one. > > This wasn't quite right, updated to check erro for ENOSYS (not rc) > > This compiles and stops the panic on WSL (with a single warning). > > I haven't tested if a version compiled on Linux will behave the same way - > but based on the error messages in the top post it looks like the behavior is > the same. Great. Thanks for testing, and for the fix! Well that all sounds like good news: it corrects the behaviour from 11.2, and also improves on the previous behaviour which I'd have accepted as a bug if anyone had reported it. So the next problem is that we don't have a consensus on whether this is the right approach, so I don't feel like I can commit it yet. Does any want to make another concrete proposal? -- Thomas Munro https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fenterprisedb.com&data=02%7C01%7Cpablo.hendrickx%40exitas.be%7Ce13b08e515cd465ca6d808d696233602%7C49c3d703357947bfa8887c913fbdced9%7C0%7C1%7C636861475311562797&sdata=4qLSN4n1kGMWIO6luNlNdvDAqV02UhQ4ArqDa%2FCulsU%3D&reserved=0