Jasmine tests passed on my machine, I will take another look once I have access to my machine.
On Mon, Aug 19, 2019, 7:57 AM Akshay Joshi <akshay.jo...@enterprisedb.com> wrote: > Hi Yosry > > Jasmine tests are failing, can you please fix those and resend the patch. > > On Fri, Aug 16, 2019 at 11:23 PM Yosry Muhammad <yosry...@gmail.com> > wrote: > >> Hi hackers, >> >> Please find attached a patch with minimal refactoring of: >> web/pgadmin/tools/sqleditor/static/js/sqleditor.js >> >> This includes merging 2 redundant functions into one and renaming some >> functions to have more expressive and consistent names. >> >> Please review ! >> Thanks. >> -- >> *Yosry Muhammad Yosry* >> >> Computer Engineering student, >> The Faculty of Engineering, >> Cairo University (2021). >> Class representative of CMP 2021. >> https://www.linkedin.com/in/yosrym93/ >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* >
