On Sun, Jun 01, 2008 at 05:41:46AM -0700, James Keenan via RT wrote:
> > Since the other tests are specified using "-tests" in the option
> > name, perhaps we should have "--code-tests" instead of just "--code"?
> > (c.f.  --core-tests and --runcore-tests).
> 
> Okay.  But to extend the consistency theme, we should then change the
> 'make' level interface to 'make code_tests' to be consistent with 'make
> src_tests', 'make run_tests', etc.

Hrm.  I was hoping it would instead choose to remain consistent with

    make coretest             # not core_test
    make fulltest             # not full_test
    make manitest             # not mani_test

I think the difference is that "make src_tests" and "make run_tests"
are really shortcuts for "run all of the tests in t/src/ or t/run/".
Thus following this pattern would mean that "make code_tests" would
"run all of the tests in t/code/"  (which is not what this is).

The coretest, fulltest, manitest, etc. targets are all "run a standard
suite of tests in preparation for checkin".  The codetest target seems 
to fall in this latter category (since like coretest it's a subset of 
"make test"), and so should probably be codetest.

Pm

Reply via email to