On Sat May 31 23:52:19 2008, pmichaud wrote:
> On Sat, May 31, 2008 at 05:54:31AM -0700, James Keenan via RT wrote:
> > Please review the patch attached, which implements your suggestion.
>
> The patch looks good to me; I just have a couple of questions
> and/or observations:
>
>
> Since the other tests are specified using "-tests" in the option
> name, perhaps we should have "--code-tests" instead of just "--code"?
> (c.f. --core-tests and --runcore-tests).
>
Okay. But to extend the consistency theme, we should then change the
'make' level interface to 'make code_tests' to be consistent with 'make
src_tests', 'make run_tests', etc.
>
> codetest :
> $(PERL) t/harness $(EXTRA_TEST_ARGS) --code-tests
>
Okay, though it will read:
code_tests :
$(PERL) t/harness $(EXTRA_TEST_ARGS) --code-tests
... as per above comment.
