On Nov 4, 2007, at 11:06 PM, Paul Cochrane via RT wrote:

kid51,

On 05/11/2007, James Keenan via RT <parrotbug- [EMAIL PROTECTED]> wrote:
The patch attached refactors configuration step auto::ctags to maximize
testability.  It also provides 3 test files to replace ptc's original
test file. ptc's original functionality is, however, maintained intact.

Assuming no objection, I'll apply this in 2-3 days.


The patch looks good.  One thing which would be a "nice to have" is
the documentation to say what the difference between the four test
files is.  Or put another way: a comment as to what specific feature
of ctags is being tested.


Agreed, and the point applies to tests for steps other than this one. I did that when I was writing tests for some of the earlier configuration steps and have made a mental note to do that for the steps I've been working on in the last two weeks.


Reply via email to