On Wednesday 02 July 2008 12:56:56 NotFound wrote:

> The imcc_init function is called from several places, and it allocates
> memory without checking if already is initialized, with potential
> memory leaking.
>
> However, it's called during interpreter creation. And putting the
> assertion:
>
> PARROT_ASSERT(IMCC_INFO(interp) == NULL);
>
> confirms that is called several tiems, breaking a lot of tests.
>
> Worse, the function lacks a prototype in an easily available header.
>
> This patch cleans the isuue by dropping all calls from all places
> except interpreter creation, and puts the assertion in place to verify
> that is not recalled, avoiding memory leaks.

Thanks, applied in r28973.

-- c

Reply via email to