Jonathan Worthington wrote:
Hi,

We have for testing isa relationships both:

INTVAL isa_pmc(PMC* lookup)
INTVAL isa(STRING* _class)

However for the does test, we have just:

INTVAL does(STRING* method)

I'm thinking we should have a does_pmc variant too?

Sensible. Make it so.

Also, I'm not sure why the name of the string taken there is method, since does tests for what roles are done, and can is for testing if a certain method is supported.

My guess is that it's a copy-n-paste error from 'can' 2 lines above. In the actual implementation in class.pmc, it's called 'role_name'. (The parameter name in vtable.tbl isn't significant.)

Allison

Reply via email to