On Sun, Nov 25, 2007 at 11:50:15AM -0800, chromatic wrote: > On Sunday 25 November 2007 10:35:01 Patrick R. Michaud wrote: > > > On Sun, Nov 25, 2007 at 09:19:20AM -0800, chromatic wrote: > > > > CONST_STRING() is 100% more awesome, because it's completely constant. > > > [...] > > > PDD 15 branch after replacing string_from_literal() with CONST_STRING(). > > > We should do this wherever possible. > > > > Totally awesome, indeed! I'll convert whenever I run > > across them -- including in the two files mentioned above. > > It doesn't *always* work. For example, I think CONST_STRING() doesn't work > in > PCCMETHODs in PMCs for some reason I can't explain, and it doesn't work in > other source files.
I converted string_literal() to CONST_STRING() inside of CodeString PMCs, and so far things seem to be working. If I start encountering GC problems I may switch it back. > Fixing that would be nifty. Amen! Pm
