On Sunday 25 November 2007 10:35:01 Patrick R. Michaud wrote: > On Sun, Nov 25, 2007 at 09:19:20AM -0800, chromatic wrote:
> > CONST_STRING() is 100% more awesome, because it's completely constant. > > [...] > > PDD 15 branch after replacing string_from_literal() with CONST_STRING(). > > We should do this wherever possible. > > Totally awesome, indeed! I'll convert whenever I run > across them -- including in the two files mentioned above. It doesn't *always* work. For example, I think CONST_STRING() doesn't work in PCCMETHODs in PMCs for some reason I can't explain, and it doesn't work in other source files. Fixing that would be nifty. (Who's reading this besides Patrick? Want to make karma fast? Figure out why, and either tell me so that I can fix it or figure out the right fix and send a patch.) -- c
