On Monday 22 October 2007 18:01:27 James Keenan via RT wrote: > While examining this file for the purpose of writing tests, I noticed > that it uses Perl's special variable $/ in 6 instances where a newline > would suffice. > > [parrot] 504 $ grep -n '$/' config/auto/attributes.pm > 54: print $/ if $verbose; > 67: $verbose and print "trying attribute '$attr'$/"; > 83: $verbose and print " ", $command_line, $/; > 88: $verbose and print " exit code: $exit_code$/"; > 95: $verbose and print " output: $output$/"; > 100: $verbose and print " ccflags: $ccflags$/"; > > Why? > > i.e., Why we do we need this here when "\n" suffices everywhere else in > the Parrot distribution?
I can't think of a reason. While you're at it, how about getting rid of the use of 'and' for flow control here by turning them into print ... if ...? (If the end-weight argument comes up, create a function that prints verbose diagnostics.) -- c
