Hi,

Attached a new version of the patch, I did some more work on cleaning up and
commenting where I could (going top-down, so not for long finished... hint
hint)

Hope this helps,

klaas-jan



On 5/18/07, Parrot via RT <[EMAIL PROTECTED]> wrote:

Greetings,

This message has been automatically generated in response to the
creation of a parrotbug regarding:
        "[PATCH] comments and minor details for debug.c"

There is no need to reply to this message right now.  Your ticket has been
assigned an ID of [perl #42992].

Please include the string:
         [perl #42992]
In the subject line of all future correspondence about this issue. To do
so,
you may reply to this message.

                        Thank you,
                          parrotbug

http://rt.perl.org/rt3/Ticket/Display.html?id=42992
-------------------------------------------------------------------------
MIME-Version: 1.0
X-Spam-Status: No, hits=-1.9 
required=8.0tests=BAYES_00,DKIM_SIGNED,DKIM_VERIFIED,DK_POLICY_SIGNSOME,DK_SIGNED,HTML_MESSAGE,SPF_NEUTRAL
Received-SPF: neutral (x1.develooper.com: 63.251.223.176 is neither
permitted nor denied by domain of [EMAIL PROTECTED])
Received-SPF: pass (x1.develooper.com: domain of [EMAIL PROTECTED]
209.85.132.251 as permitted sender)
X-Old-Spam-Check-BY: la.mx.develooper.com
Content-Type:
multipart/mixed;  boundary="----=_Part_61229_23570530.1179502282138"
Message-ID: <[EMAIL PROTECTED]>
Received: (qmail 32237 invoked by alias); 18 May 2007 15:31:51 -0000
Received: (qmail 32232 invoked from network); 18 May 2007 15:31:51 -0000
Received: from localhost (HELO la.mx.develooper.com) (127.0.0.1) by
localhost with SMTP; 18 May 2007 15:31:51 -0000
Received: (qmail 32227 invoked by alias); 18 May 2007 15:31:50 -0000
Received: from la.mx.develooper.com (HELO x1.develooper.com) (
63.251.223.176) by la.mx.develooper.com (qpsmtpd/0.28) with SMTP; Fri, 18
May 2007 08:31:43 -0700
Received: (qmail 32165 invoked by uid 225); 18 May 2007 15:31:39 -0000
Received: (qmail 32161 invoked by alias); 18 May 2007 15:31:38 -0000
Received: from an-out-0708.google.com (HELO an-out-0708.google.com) (
209.85.132.251) by la.mx.develooper.com (qpsmtpd/0.28) with ESMTP; Fri, 18
May 2007 08:31:30 -0700
Received: by an-out-0708.google.com with SMTP id b38so266370ana for <
[EMAIL PROTECTED]>; Fri, 18 May 2007 08:31:26 -0700 (PDT)
Received: by 10.114.110.1 with SMTP id i1mr890764wac.1179502282300; Fri,
18 May 2007 08:31:22 -0700 (PDT)
Received: by 10.114.193.2 with HTTP; Fri, 18 May 2007 08:31:22 -0700 (PDT)
Delivered-To: [EMAIL PROTECTED]
Delivered-To: [EMAIL PROTECTED]
Delivered-To: [EMAIL PROTECTED]
Subject: [PATCH] comments and minor details for debug.c
Return-Path: <[EMAIL PROTECTED]>
Domainkey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
h=received:message-id:date:from:to:subject:mime-version:content-type;
b=T8x3DgwUJEutnqdqPE+SEPLwlwYlf9qL0R0qr0Hy5QauZjQZM4At3mzcrMQjtuMwNNGceLvSjLsR/gNauS/s5NKxEsoy2tdXDTtEBg4c2MOE6xJ8tCLsXqUOAJyh7FQ/vPg2GfJhKZwI5yKl+WvnGzOVZditCYap+VCL16WroCM=
X-Spam-Check-BY: la.mx.develooper.com
Dkim-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta;
h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type;
b=JEOa/iQ9e5XzAJbtt950slip+nph0QyFB2QXwEN88Ye4kS8u7dQVFVdSVEM/dvpS+KiKAC7XuZBdu4tLtEw0ckf2lXdhFxHrxrxPotd35VyzhCZKCWNrFsXSbnx5czZWHaSwZXb3qxtnR19JHHHAKqjcZ8V4a9IRhzKhVFgFDdw=
X-Old-Spam-Status: No, hits=-2.6 
required=8.0tests=BAYES_00,DKIM_SIGNED,DKIM_VERIFIED,DK_POLICY_SIGNSOME,DK_SIGNED,HTML_MESSAGE,SPF_PASS
Date: Fri, 18 May 2007 23:31:22 +0800
To: [EMAIL PROTECTED]
From: "Klaas-Jan Stol" <[EMAIL PROTECTED]>

Hi,

attached a patch starting a bit of cleanup for debug.c

* pointer declarations should be done like <type> <space> *<id> instead of
the space after the *.
-> so "int *p" instead of "int* p". Fixed this in a few places. (according
to PDD07). many more to fix, though.

* added some comments here and there.

Hope this helps,

kjs


Attachment: debugpatch2.patch
Description: Binary data

Reply via email to