James E Keenan wrote:
File src/pmc/classobject.h was added very recently:
r18244 | jonathan | 2007-04-16 19:26:34 -0400 (Mon, 16 Apr 2007) | 1 line
Aye.
I'm wondering why it was added in directory src/pmc/. Previously,
that directory held only files with names ending in .num or .pmc:
[parrot] 527 $ ls src/pmc/ | cut -d '.' -f 2 | sort | uniq -c
1 num
81 pmc
These were the 'pmc' files transformed by tools/build/pmc2c.pl into c
files. Is src/pmc/ the most appropriate location for a .h file?
Only the Class and Object PMCs need this header file. Nothing else
should include it. It's part of my attempt to encourage encapsulation. I
was following the precedent that src/ contains some .h files (I guess,
for a similar reason). I'm pretty sure I've seen .h files show up in
languages PMC directories too.
The fact that you've pointed out its unusual for a .h file to be there
is perhaps a good thing, 'cus anyone thinking of including it themselves
will hopefully think the same. ;-) If anyone feels really strongly
otherwise, I won't be bothered if it gets moved.
Jonathan
