Jonathan Worthington wrote:
Oops, forgot to Reply To All...
------------------------------------------------------------------------
Subject:
Re: src/pmc/classobject.h: Why is it in this directory?
From:
Jonathan Worthington <[EMAIL PROTECTED]>
Date:
Mon, 23 Apr 2007 16:55:32 +0100
To:
James E Keenan <[EMAIL PROTECTED]>
To:
James E Keenan <[EMAIL PROTECTED]>
James E Keenan wrote:
I stumbled across it because I was re-running the build tools tests in
t/tools/pmc2cutils/*.t.
[parrot] 502 $ prove -v t/tools/pmc2cutils/00-qualify.t
t/tools/pmc2cutils/00-qualify....1..9
ok 1 - use Parrot::Pmc2c::Utils;
ok 2 - Makefile located
ok 3 - myconfig located
ok 4 - lib/Parrot/PMC.pm located
not ok 5 - only 2 file suffixes in src/pmc
# Failed test 'only 2 file suffixes in src/pmc'
# at t/tools/pmc2cutils/00-qualify.t line 26.
# got: '3'
# expected: '2'
...
# Looks like you failed 1 test of 9.
dubious
Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 5
Failed 1/9 tests, 88.89% okay
Failed Test Stat Wstat Total Fail List of Failed
-------------------------------------------------------------------------------
t/tools/pmc2cutils/00-qualify.t 1 256 9 1 5
Failed 1/1 test scripts. 1/9 subtests failed.
Files=1, Tests=9, 2 wallclock secs ( 0.25 cusr + 0.13 csys = 0.38 CPU)
Failed 1/1 test programs. 1/9 subtests failed.
Aha, sorry. I've tried to get myself into the habit of running those
tests when I change pmc2c, though this change didn't do that, so I never
spotted it.
Now, granted, the test that failed may have been written in a too
restrictive manner. But I was trying to determine which files in
src/pmc/ I needed to copy to a temporary directory for the purpose of
running tests later in the test suite.
Since I use src/pmc/class.pmc later in the test suite, I may have to
reformulate a test there as well:
[parrot] 506 $ grep -n 'src/pmc/class' t/tools/pmc2cutils/*.t
t/tools/pmc2cutils/05-gen_c.t:286: my @pmcfiles = (
"$main::topdir/src/pmc/default.pmc",
"$main::topdir/src/pmc/class.pmc", );
Couldn't you could just allow there to be .h files in there, provided
they don't start with "pmc_" (and therefore we know they ain't leftovers
from an uncleaned tree)?
Okay, I've hacked up t/tools/pmc2cutils/00-qualify.t and committed in to
trunk. Jonathan, can you take a look at it and the 05 test in the same
directory (which makes reference to the Class PMC)? Thanks.
