On Mar 25, 2007, at 9:34 PM, James Keenan (via RT) wrote:
# New Ticket Created by James Keenan
# Please include the string: [perl #42082]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=42082 >
Ongoing refactoring of Configure.pl in the 'reconfigure' branch
suggests two bugs in Configure.pl.
1. Configure.pl has a lexical @valid_opts (starting at line 284 for
me). One of the elements of this array is: 'verbose-step=N'.
Shouldn't this really be: 'verbose-step'?
Configure.pl uses verbose-step=N which obviously looks wrong, and
lib/Parrot/Configure.pm uses verbose-step. Does verbose-step=N or
verbose-step=regex even work? There's probably an rt ticket or two
about it(or just no one uses the option which may be the case).
2. The POD for Configure.pl documents two options which are not
found in @valid_opts: 'bison_required' and 'flex_required'. Are
these old options that have been removed? If so, the corresponding
POD should also be deleted.
At the same time, is the check even made and made properly? When
parrot started needing 2.5.33, my config.sh script worked just fine,
until imclexer.c needing updating and my build failed. And still, I
only have 2.5.4 in my path yet Configure.pl still works just fine with
me setting --lex=flex.
Here is a patch that will correct these problems in trunk.
kid51
Index: Configure.pl
===================================================================
--- Configure.pl (revision 17743)
+++ Configure.pl (working copy)
@@ -142,18 +142,10 @@
Specify which lexer to use.
-=item C<--flex_required=X.Y.Z>
-
-Override the minimum acceptable flex version.
-
=item C<--yacc=(parser)>
Specify which parser to use.
-=item C<--bison_required=X.Y>
-
-Override the minimum acceptable bison version.
-
=item C<--define=val1[,val2]>
Generate "#define PARROT_DEF_VAL1 1" ... entries in has_header.h.
Currently
@@ -295,7 +287,7 @@
jitcapable ld ldflags lex libdir libexecdir libs link linkflags
localstatedir m maintainer mandir miniparrot nomanicheck
oldincludedir
opcode ops optimize parrot_is_shared pmc prefix profile sbindir
- sharedstatedir step sysconfdir verbose verbose-step=N version
without-gdbm
+ sharedstatedir step sysconfdir verbose verbose-step version
without-gdbm
without-gmp without-icu yacc);
my %args;
