On Sun Mar 25 23:00:09 2007, [EMAIL PROTECTED] wrote: > > On Mar 25, 2007, at 9:34 PM, James Keenan (via RT) wrote: > > > > > 1. Configure.pl has a lexical @valid_opts (starting at line 284 for > > me). One of the elements of this array is: 'verbose-step=N'. > > Shouldn't this really be: 'verbose-step'? > > Configure.pl uses verbose-step=N which obviously looks wrong,
Yes, because it appends the value to the key. > and lib/Parrot/Configure.pm uses verbose-step. ... which looks correct, though I haven't tried it. > Does verbose-step=N or > verbose-step=regex even work? There's probably an rt ticket or two > about it(or just no one uses the option which may be the case). > > > 2. The POD for Configure.pl documents two options which are not > > found in @valid_opts: 'bison_required' and 'flex_required'. Are > > these old options that have been removed? If so, the corresponding > > POD should also be deleted. > > At the same time, is the check even made and made properly? When > parrot started needing 2.5.33, my config.sh script worked just fine, > until imclexer.c needing updating and my build failed. And still, I > only have 2.5.4 in my path yet Configure.pl still works just fine with > me setting --lex=flex. > I haven't looked into that yet. In the course of my refactoring (which you can look at in the 'reconfigure' branch), I happened to write a test that examined the POD in Configure.PL and compared the options documented there to those found in @valid_opts (which, in that branch, is now in lib/Parrot/Configure/Options.pm). The test pointed out the three discrepancies I reported. kid51
