Re: [perl #41020] [PATCH] pmc2c.pl functionality extracted into separate package

[James Keenan]

On Dec 30, 2006, at 2:56 PM, chromatic via RT wrote:

Here's what I get on an x86 Linux machine:

/usr/bin/perl t/harness t/tools/pmc2cutils/00-qualify.t
[snip]
t/tools/pmc2cutils/01-pmc2cutils.....
#     Failed test (t/tools/pmc2cutils/01-pmc2cutils.t at line 48)
#     Parrot::Pmc2c::Utils->can('add_defaulted') failed
# Looks like you failed 1 test of 28.
dubious
        Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 18
        Failed 1/28 tests, 96.43% okay
t/tools/pmc2cutils/02-find_file......ok
t/tools/pmc2cutils/03-dump_vtable....ok
t/tools/pmc2cutils/04-dump_pmc.......
#     Failed test (t/tools/pmc2cutils/04-dump_pmc.t at line 478)
#          got: '1167508484'
#     expected: '1167508487'
# Looks like you failed 1 test of 107.
dubious
        Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 94
        Failed 1/107 tests, 99.07% okay
t/tools/pmc2cutils/05-gen_c..........ok
t/tools/pmc2cutils/06-print_tree.....ok
t/tools/pmc2cutils/07-open_file......ok

t/tools/pmc2cutils/01-pmc2cutils.t    1   256    28    1  18
t/tools/pmc2cutils/04-dump_pmc.t      1   256   107    1  94
Failed 2/8 test scripts. 2/297 subtests failed.

Failed Test Stat Wstat Total Fail List of Failed ---------------------------------------------------------------------- ---------

You didn't get the most recent version of the tests.

I think part of the problem is that, in the case of the 8 test files and lib/Parrot/Pmc2c/Utils.pm, I was submitting completely new files (hence, svn adds) rather than patching existing files. Since I don't have commit privileges, I was dependent on others to commit them for me. tewk generously offered to do that. But from the time I began to submit what I think are correct files, I kept making revisions and submitting patches to RT. So different versions of as-yet-never-committed files were available on RT. What ended up getting an svn commit was not the latest version of certain files. In particular, I had deleted the 'add_defaulted' subroutine from lib/Parrot/Pmc2c/Utils.pm and the corresponding test in 01- pmc2cutils.t, but the version of 01-pmc2cutils.t that got committed still had a test for the deleted subroutine. Hence, your failure above.

00-qualify.t.patch
Description: Binary data

00-qualify.t.patch
01-pmc2cutils.t.patch
04-dump-pmc.t.patch
Utils.pm.patch

Please see if these pass the tests.  They are passing on my Mac (PPC):

[parrot] 530 $ pwd
/Users/jimk/work/parrot
[parrot] 531 $ perl t/harness t/tools/pmc2cutils/*.t
t/tools/pmc2cutils/00-qualify........ok
t/tools/pmc2cutils/01-pmc2cutils.....ok
t/tools/pmc2cutils/02-find_file......ok
t/tools/pmc2cutils/03-dump_vtable....ok
t/tools/pmc2cutils/04-dump_pmc.......ok
t/tools/pmc2cutils/05-gen_c..........ok
t/tools/pmc2cutils/06-print_tree.....ok
t/tools/pmc2cutils/07-open_file......ok
All tests successful.

[parrot] 532 $ prove t/tools/pmc2cutils/*.t
t/tools/pmc2cutils/00-qualify........ok
t/tools/pmc2cutils/01-pmc2cutils.....ok
t/tools/pmc2cutils/02-find_file......ok
t/tools/pmc2cutils/03-dump_vtable....ok
t/tools/pmc2cutils/04-dump_pmc.......ok
t/tools/pmc2cutils/05-gen_c..........ok
t/tools/pmc2cutils/06-print_tree.....ok
t/tools/pmc2cutils/07-open_file......ok
All tests successful.


kid51

Since these files are now in the repository, I can do svn diffs against the head. So I am attaching svn diffs of 3 files: Files=8, Tests=308, 27 wallclock secs (16.76 cusr + 3.71 csys = 20.47 CPU) Files=8, Tests=308, 25 wallclock secs (16.66 cusr + 3.60 csys = 20.26 CPU)

Utils.pm.patch
Description: Binary data

04-dump-pmc.t.patch
Description: Binary data

01-pmc2cutils.t.patch
Description: Binary data