On 10/17/06, Kevin Tew <[EMAIL PROTECTED]> wrote:
1) *s should go right next to the type in function declarations and
definitions
I disagree; they should go right next to the name being declared,
since C declarations are designed to reflect the way the declared item
is later used: PMC *pmc, visit_info *info.
2) All structs should be typedefed
That seems reasonable. What about struct names? Around here we
require that all structs have both a struct name and a typedef, and
the two names match:
typedef struct foo {...} foo;
It's redundant except when you need to declare a self-referential
pointer, of course, but consistency for consistency's sake isn't
always bad. :)
3) Single line if and elses are acceptable
I personally don't like that. I'd rather go tthe other way and
require curlies always.
4) c89 allows declaration and initialization on the same line right?
INTVAL counter = 0;
Sure. Even pre-ANSI C allows that.
--
Mark J. Reed <[EMAIL PROTECTED]>
