While exploring Parrot internals I started cleaning up some code.
I'll post patches to the list, but here are some things that are not
defined by the coding standards, but of which I'm a fan.
So the question is are they acceptable in the parrot code base.
1) *s should go right next to the type in function declarations and
definitions
/* incorrect */
do_thaw(Parrot_Interp interpreter, PMC * pmc, visit_info *info)
/* correct */
do_thaw(Parrot_Interp interpreter, PMC* pmc, visit_info* info)
2) All structs should be typedefed
3) Single line if and elses are acceptable
/*old*/
if (!info->thaw_result)
info->thaw_result = pmc;
else
*info->thaw_ptr = pmc;
/*new*/
if (!info->thaw_result) info->thaw_result = pmc;
else *info->thaw_ptr = pmc;
4) c89 allows declaration and initialization on the same line right?
INTVAL counter = 0;
Kevin
