On Oct 9, 2006, at 5:51 AM, Paul Cochrane (via RT) wrote:
# New Ticket Created by "Paul Cochrane" # Please include the string: [perl #40482] # in the subject line of all future correspondence about this issue. # <URL: http://rt.perl.org/rt3/Ticket/Display.html?id=40482 > Hi, This patch adds a new policy for the Parrot Perl::Critic tests, namely to check that the shebang line doesn't use 'perl -w', rather 'use warnings;' and that the shebang line doesn't use something unix specific such as '#!/usr/bin/perl' and rather '#! perl'. Would it be a good idea to group all of the code standards-related stuff into a directory CodeStandards? As such, should I then make a patch for CodeLayout::UseParrotCoda to go under CodeStandards::UseParrotCoda instead?
They're all coding standards. I say leave the Coda where it is, and put this in the same grouping as 'use warnings' (i.e. 'TestingAndDebugging').
Also, instead of checking for "/usr/local" and then reporting a violation, switch it. Check for the *allowed* version, and, failing that, report a violation. Then you'll catch /sw/bin/perl, /opt/bin/ perl, C:\perl\bin\perl.exe, and others.
Modulo that, this is good, and should be applied. (And addresses the other end of the "switch from -w to use warnings" ticket that Jerry opened.)
I'm also wondering what the policy is on svn Id keywords in files, and whether or not the svn:keywords property is set to a particular value. I don't think there's a standard or anything defined for this yet. Should there be? If so, should I put a request into RT?
This is already tested in t/distro/file_metadata.t.
TIA Regards, Paul
<PATCH_SNIPPED> -- Will "Coke" Coleda [EMAIL PROTECTED]
