On Oct 10, 2006, at 11:03 AM, Paul Cochrane wrote:
I've been playing around for a while with the shebang line tests, and
it struck me that the is_script() function will return true on your
contrived example.
Yeah, I saw that and fixed it in SVN yesterday. :-) It now checks
that column == 1 too.
Also, the fact that you mention that the shebang should be the first
line lead me to think that maybe we could look for misplaced shebang
lines, and report an error there as well. I've got a patch for that
and can send this in too if you want.
Interesting idea. You'll have to ensure it's a PPI::Token::Comment
and not a PPI::Token::Quote, for example.
Perhaps further discussion should move to the perlcritic.tigris.org
dev mailing list or to
http://rt.cpan.org/Dist/Display.html?Queue=perl-critic
Chris
--
Chris Dolan, Software Developer, Clotho Advanced Media Inc.
608-294-7900, fax 294-7025, 1435 E Main St, Madison WI 53703
vCard: http://www.chrisdolan.net/ChrisDolan.vcf
Clotho Advanced Media, Inc. - Creators of MediaLandscape Software
(http://www.media-landscape.com/) and partners in the revolutionary
Croquet project (http://www.opencroquet.org/)
