On 7/28/06, jerry gay <[EMAIL PROTECTED]> wrote:
On 7/28/06, jerry gay <[EMAIL PROTECTED]> wrote: > thanks for the effort! however, i don't want to apply this patch as it > is. 're_tests' was stolen directly from perl5's test suite. the idea > is that the test data this file contains is > implementation-independent. therefore, if some other crazy person > (besides patrick) wants to implement yet another perl5 regex engine, > they can use the same test data file, and a harness that is particular > to their implementation. > > so, i think it's best to keep the information as to which tests are > todo and which are skip out of the test data file. currently, this > information exists in the test harness, 'p5rx.t', as i think this is > the best place to capture it. i'm glad to see you've expanded the pge > p5 tests to the full 900+ tests in the file, and i'll gladly apply a > patch that does this while leaving the 're_tests' file intact. > i forgot to mention something here... patrick has included the todo / skip markers in the perl6 regex test file, and i don't think they belong there, either. these should be factored out into the harness, as well. i have other plans for those tests, like splitting them up into seperate files, but that's another story.
I made another patch for 01-regex.t to move the todo and skip tests out form regex_tests, giving the same documentation as I did for p5rx.t. Hopefully this wasn't too soon of a change, considering:
i think the best way for me to document all this is to write up some tickets, so i'll be doing that shortly.
Regardless, I'll try to work on the tickets when you post them.
David
01-regex.patch
Description: Binary data
