On 7/28/06, jerry gay <[EMAIL PROTECTED]> wrote:
thanks for the effort! however, i don't want to apply this patch as it is. 're_tests' was stolen directly from perl5's test suite. the idea is that the test data this file contains is implementation-independent. therefore, if some other crazy person (besides patrick) wants to implement yet another perl5 regex engine, they can use the same test data file, and a harness that is particular to their implementation.so, i think it's best to keep the information as to which tests are todo and which are skip out of the test data file. currently, this information exists in the test harness, 'p5rx.t', as i think this is the best place to capture it. i'm glad to see you've expanded the pge p5 tests to the full 900+ tests in the file, and i'll gladly apply a patch that does this while leaving the 're_tests' file intact. while i'm thinking about it, there should be a better way to reflect todo or skip reason. if you're up for the challenge, it would be nice to be able to say something like my %todo= ( # similar for skip 'not yet implemented' => qw< 5 12 35 500 >, 'broken' => qw< 34 63 11 >, ... ); and have something that decorates the subtests appropriately. that's not a requirement for the resubmission of your existing patch, but an extra request. if it doesn't get done this time around, it will eventually ;)
Thanks for the feedback, Jerry. I changed the re_tests to not have TODO and SKIP in the descriptions. I also changed the documentation for p5rx.t to say that @todo_tests and @skip_tests now contain the test numbers along with the reason why a certain test is skipped or todo'ed. I attached the patch. David
p5rx.patch
Description: Binary data
