On Mon, Nov 28, 2005 at 04:45:33PM -0800, jerry gay wrote: > the parrot directory structure is large and a bit disorganized. > let me give you some examples: > * build_tools/, util/, and tools/*/ each contain utility perl > scripts. these should be grouped together under tools/, which > already contains subdirectories
Sounds reasonable. > * there are multiple dirs containing C source code (charset, > classes, io, etc.) these should be grouped together under src/ I've found that reorganizing source trees tends to expose lots of build dependency problems so it's probably worth doing for that reason alone. However, it should be done with some caution and lots of warning for those that have uncommitted changes. > * the editor/ directory contains files for text editors and has > a generated makefile. there is no reason for this to be a make > target. a perl script should be created to replace makefile, > and the dir moved with the other tool & utility scripts. I disagree. A Perl script won't do any better of a job and will be more complex then that rather simple makefile. > * imcc test files are not grouped with other tests (this is > already on my TODO list and should be done RSN.) Does it make sense for the tests to even refer to imcc? IMHO Parrot ability to digest PIR is whats really being tested. However unlikely, it's worth keeping in ind that Parrots internal PIR compiler may be replaced someday. > i propose reorganizing the tree to improve clarity and cohesion. > here is an annotated picture of the current tree (extra info > <snip>ped as shown.) [SNIP] > this work can and should be done one piece at a time to prevent > widespread panic. if this proposal is accepted, i will create > todo tasks for each unit of work. then, they can be assigned one > at a time, until the task is complete. of course, a realclean / > configure / make test cycle should be done after each change to > ensure it has gone smoothly. I'd suggest that you consider making the change in two phases. With all of the non-"move it under /src" changes first as it will cause less disruption in the tree. Cheers, -J --
pgpKeQ3QkX6G5.pgp
Description: PGP signature
