Mike Lambert wrote:
> Wow. Tinderbox gave us fall and spring in a few hour period. Nice. Here's
> a patch to help make us make it to summer again.

Steve actually pointed out that this style of code was not safe, but I still
managed to miss that one.

> -        (char *)cur_buffer += pool->unit_size;
> +        cur_buffer += (Buffer *)((char *)cur_buffer + pool->unit_size);

That should be
> +        cur_buffer = (Buffer *)((char *)cur_buffer + pool->unit_size);

--
Peter Gibbs
EmKel Systems
 Index: resources.c
 ===================================================================
 RCS file: /cvs/public/parrot/resources.c,v
 retrieving revision 1.51
 diff -u -r1.51 resources.c
 --- resources.c 5 May 2002 04:02:59 -0000       1.51
 +++ resources.c 5 May 2002 05:28:36 -0000
 @@ -213,7 +213,7 @@
      for (i = 0; i < pool->units_per_alloc; i++) {
          cur_buffer->flags = BUFFER_on_free_list_FLAG;
          add_to_free_pool(interpreter, pool, cur_buffer);
 -        (char *)cur_buffer += pool->unit_size;
 +        cur_buffer = (Buffer *)((char *)cur_buffer + pool->unit_size);
      }
  }


Reply via email to