Bryan, this is good stuff! One question though- in this section of the patch:
> - /* file header comments */ > - > - #if !defined(PARROT_<FILENAME>_H_GUARD) > - #define PARROT_<FILENAME>_H_GUARD > - > - /* body of file */ > - > - #endif /* PARROT_<FILENAME>_H_GUARD */ > + /* file header comments */ > + > + #if !defined(PARROT_<FILENAME>_H_GUARD) > + #define PARROT_<FILENAME>_H_GUARD > + > + /* body of file */ > + > + #endif /* PARROT_<FILENAME>_H_GUARD */ This doesn't agree with how we've been doing cpp directive indenting in two ways. First, we've been keeping the "#" on the leftmost column and putting spaces after that. Second, I decded not to increase the indenting level for "_GUARD" ifdefs. This was just an aesthetic thing- i didn't like the fact that it means that basically everything (including #includes) would end up indented in every header file. --Josh
