Gibbs Tanton - tgibbs:
# Here is the parrot/config.h patch
#
# It fixes Makefile.in, but not in the correct way. Brent, if
# you could look
# at this and fix it the right way I would really appreciate it
# (note that I
# have no clue what the right way is :)
It's understandable that you couldn't find the right way--it was in
Configure.pl, not Makefile.in. In fact, that seems to be the only
change necessary--so I now present to you the full, complete, unabridged
patch for this feature:
--- c:\old_parrot\Configure.pl Fri Sep 14 08:06:22 2001
+++ Configure.pl Fri Sep 14 08:15:56 2001
@@ -28,11 +28,16 @@
#Some versions don't seem to have ivtype or nvtype--provide
#defaults for them.
#XXX Figure out better defaults
+#NOTE: This is the correct place to set defaults, not Makefile.in
+#or config_h.in.
my(%c)=(
iv => ($Config{ivtype}||'long'),
nv => ($Config{nvtype}||'long double'),
cc => $Config{cc},
- ccflags => $Config{ccflags},
+ #XXX This may not be correct, since we'll capture options like
+ #-DDEBUGGING too; however, this is what the version in CVS was
+ #like.
+ ccflags => $Config{ccflags}." -I..",
libs => $Config{libs}
);
:^)
As you can see, I also put in a note in the future for others who can't
find the right place to set defaults, as well as an XXX involving
whether we should 'inherit' ccflags at all.
--Brent Dax
[EMAIL PROTECTED]
They *will* pay for what they've done.
