Hi Samuel, Thanks for your review.
On Tue, Sep 17, 2024 at 7:21 PM Samuel Sidor (ssidor) <ssidor= 40cisco....@dmarc.ietf.org> wrote: > Hi Julien and PCE WG, > > I support progress of this document. > > 3 minor (non-blocking) comments: > 1. Do we need to expand "PCEP" in document title? (It seems to be expanded > in most of PCEP RFCs) > Dhruv: Fixed as "Update to the IANA PCE Communication Protocol (PCEP) Registration Procedures and Allowing Experimental Error Codes"; PCE is marked as well-known by RFC-Editor https://www.rfc-editor.org/rpc/wiki/doku.php?id=abbrev_list > 2. In section 3.1, shouldn't we use normative SHOULD/MUST when specifying > what an "experiment" should/will do? (I understand that the whole section > is even called as "Advice ...", so it seems that it is not really > specifying requirements. However, in reality, it seems to be defining > required behavior for anyone using experimental error types/values. Dhruv: I personally prefer to not use normative keywords when they do not apply to protocols or their implementations :) > 3. Just a note: If I haven't missed anything, American English is used in > most of PCEP drafts. I can see a few words from British English > ("recognise", "synchronised",..) in this draft. That should be fine as long > as we are not mixing American and British English in a single document (I > don't see a specific example of some a word that would be specific to > American English. I'm just raising this because there is a chance that > could happen during merge of 2 drafts into current one). > > Dhruv: Thanks. Fixed. Commit -> https://github.com/ietf-wg-pce/draft-ietf-pce-iana-update/commit/493c08e19c56fc3a72d6c4102e230173de01d2e0 Diff -> https://author-tools.ietf.org/api/iddiff?doc_1=draft-ietf-pce-iana-update&url_2=https://ietf-wg-pce.github.io/draft-ietf-pce-iana-update/draft-ietf-pce-iana-update.txt Thanks! Dhruv > Thanks a lot, > Samuel > > -----Original Message----- > From: julien.meu...@orange.com <julien.meu...@orange.com> > Sent: Friday, September 6, 2024 2:24 PM > To: pce@ietf.org > Subject: [Pce] WG Last Call for draft-ietf-pce-iana-update > > Hi all, > > Since we have consensus, let's move forward with this simple fix to [1], > as agreed with the IESG. This message starts a 2-week WG last call for > draft-ietf-pce-iana-update-01 [2]. Please share your support or comments > on the PCE mailing list by Friday September 20. > > Thank you, > > Julien > > > [1] https://www.rfc-editor.org/cluster_info.php?cid=C519 > [2] https://datatracker.ietf.org/doc/html/draft-ietf-pce-iana-update-01 > > _______________________________________________ > Pce mailing list -- pce@ietf.org > To unsubscribe send an email to pce-le...@ietf.org >
_______________________________________________ Pce mailing list -- pce@ietf.org To unsubscribe send an email to pce-le...@ietf.org
