Hi Mike, Thanks for addressing the comments, looks good to me.
Regarding section 6.5 - is it worth making the text identical to match https://datatracker.ietf.org/doc/html/draft-ietf-idr-bgp-ls-sr-policy-03#section-8.4 since I assume the intent is for both of these docs to use the same registry under Segment Routing? Naturally makes sense to not define values outside of the PCEP scope, however might be worth making sure the descriptions match even if they may appear redundant (i.e code point 1, 10, 20, 30). Comparing the two it's also not clear to me what code point value 1 is in IDR vs unassigned in PCEP. With that said, considering IDR was proposing similar and the origins can be common amongst many different protocols, think it makes sense to have the registry under Segment Routing. Thanks Andrew On 2024-01-16, 11:48 PM, "Pce on behalf of Mike Koldychev" <pce-boun...@ietf.org <mailto:pce-boun...@ietf.org> on behalf of mkoldych=40proton...@dmarc.ietf.org <mailto:40proton...@dmarc.ietf.org>> wrote: Hi WG, I addressed all comments that I received so far (let me know if I missed anything). I copied some text from [I-D.ietf-idr-segment-routing-te-policy] into Section 5.3, to avoid making a normative reference to that draft. So we should probably review it again in more detail. Also, we need to double check Section 6.5 (https://datatracker.ietf.org/doc/html/draft-ietf-pce-segment-routing-policy-cp-13#section-6.5 <https://datatracker.ietf.org/doc/html/draft-ietf-pce-segment-routing-policy-cp-13#section-6.5>), to make sure it's a good idea to create the new registry under Segment Routing instead of under PCEP. Thanks, Mike. Sent with Proton Mail secure email. On Tuesday, January 16th, 2024 at 7:48 PM, internet-dra...@ietf.org <mailto:internet-dra...@ietf.org> <internet-dra...@ietf.org <mailto:internet-dra...@ietf.org>> wrote: > A new version of Internet-Draft > draft-ietf-pce-segment-routing-policy-cp-13.txt has been successfully > submitted by Mike Koldychev and posted to the > IETF repository. > > Name: draft-ietf-pce-segment-routing-policy-cp > Revision: 13 > Title: PCEP Extensions for SR Policy Candidate Paths > Date: 2024-01-16 > Group: pce > Pages: 23 > URL: > https://www.ietf.org/archive/id/draft-ietf-pce-segment-routing-policy-cp-13.txt > > <https://www.ietf.org/archive/id/draft-ietf-pce-segment-routing-policy-cp-13.txt> > Status: > https://datatracker.ietf.org/doc/draft-ietf-pce-segment-routing-policy-cp/ > <https://datatracker.ietf.org/doc/draft-ietf-pce-segment-routing-policy-cp/> > HTMLized: > https://datatracker.ietf.org/doc/html/draft-ietf-pce-segment-routing-policy-cp > > <https://datatracker.ietf.org/doc/html/draft-ietf-pce-segment-routing-policy-cp> > Diff: > https://author-tools.ietf.org/iddiff?url2=draft-ietf-pce-segment-routing-policy-cp-13 > > <https://author-tools.ietf.org/iddiff?url2=draft-ietf-pce-segment-routing-policy-cp-13> > > Abstract: > > A Segment Routing (SR) Policy is a non-empty set of SR Candidate > Paths, which share the same <headend, color, endpoint> tuple. SR > > Policy is modeled in PCEP as an Association of one or more SR > Candidate Paths. PCEP extensions are defined to signal additional > attributes of an SR Policy. The mechanism is applicable to all SR > forwarding planes (MPLS, SRv6, etc.). > > > > The IETF Secretariat _______________________________________________ Pce mailing list Pce@ietf.org <mailto:Pce@ietf.org> https://www.ietf.org/mailman/listinfo/pce <https://www.ietf.org/mailman/listinfo/pce> _______________________________________________ Pce mailing list Pce@ietf.org https://www.ietf.org/mailman/listinfo/pce
