On Tue, Nov 07, 2017 at 05:23:54PM +0100, Sebastian Parschauer wrote: > Hi, > > this is v3 of this patch. I'm sending a patch set due to the > introduction of the force option. > > Changes compared to v2: > * keep printing warnings in script mode > * introduce different warnings for script mode > * add force option (-f, --force) > * use force option to enforce shrinking and removing busy partitions
At first glance (I haven't tried this patch set yet) this looks pretty good to me, except: 1. I think force is too generic, it implies that it will allow all dangerous actions in all the commands. I think it should be named something more limiting. --ignore-busy, or --force-shrink, or ? 2. This should include tests. Thanks! -- Brian C. Lane (PST8PDT)
