https://bugzilla.redhat.com/show_bug.cgi?id=2437604
Jens Petersen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #9 from Jens Petersen <[email protected]> --- I think you broke the build with: -mkdir -p %{buildroot}/etc/systemd/system/ -cp %{S:1} %{buildroot}/etc/systemd/system/ +cp %{S:1} %{buildroot}/%{_unitdir} The directory still needs to be created: if you don't want to create it separately you could use say install -Dp -m 0644 -t %{buildroot}/%{_unitdir} %{S:1} Otherwise the package looks fine to me: - MIT license (most of the src files are tagged) - complies with Haskell Packaging guides - cabal-rpm spec file with small tweaks I tested it lightly in a VM with the following "test.kbd" config file: ``` (defcfg input (device-file "/dev/input/event1") output (uinput-sink "KMonad-Test-Device") fallthrough true allow-cmd false ) (defsrc caps ) (deflayer default esc ) ``` using both `sudo kmonad test.kbd` and `systemctl start kmonad@test` (for `/etc/kmonad/test.kbd`) Package is APPROVED Please fix the above minor build issue when importing :) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2437604 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437604%23c9 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
