https://bugzilla.redhat.com/show_bug.cgi?id=2437604
--- Comment #4 from Jens Petersen <[email protected]> --- Overall this looks good. (Btw I am going to add -prof-static provides to cabal-rpm in the following release.) I checked the upstream git submodules but they are only for macos, so I think they can be ignored here. I think the unit tests could be enabled: cabal-rpm can do that - you might need to install ghc-hspec-devel. Also the systemd unit should live under %{_unitdir} (not /etc/). (Arguably it might be more consistent to take the systemd file from the release tag, though it hasn't changed since.) (It wouldn't hurt if upstream included the file in the tarball, though I don't think it's a blocker.) Further the systemd unit should live in the main kmonad package (it doesn't pull in ghc-kmonad). You can add `doc/quick-reference.md` to the kmonad %doc's I think, maybe also `keymap/tutorial.kbd`. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2437604 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437604%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
