https://bugzilla.redhat.com/show_bug.cgi?id=2431607
--- Comment #11 from Maxwell G <[email protected]> --- (In reply to Zdenek Dohnal from comment #7) > (In reply to Maxwell G from comment #5) > > Package approved, but I noticed two other minor things to change before you > > import the package: > > > > > > > %files > > > %{_mandir}/man8/ipp-usb.8.* > > > > * Please change this > > > > to %{_mandir}/man8/ipp-usb.8* > > > > to match the format in > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages. > > Np, I will change it. Just curious - do you know the reason behind the > format? Man pages are automatically compressed during RPM build, so they > will be in format 'name.N.<compression format>', where IMO compression > format can change, thus the suffix wildcard. I guess the suggested format would also work if we stopped compressing manpages entirely while the one that assumes a dot at the end would not. > > > %{_sbindir}/ipp-usb > > > > * I would just reference %{_bindir} here and in %install now that /usr/sbin > > -> /usr/bin (https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin) > > A fair point - I've checked the functionality 'ipp-usb check' worked fine, > so LGTM atm. :+1: > I use 'fedora-review' tool to check the package - how can I run this > specific package review automatically? I see you have the checklist on your > git, but I don't know how to run it - or you do it manually? Manually :). I just wanted to make a simple checklist as a shortened version of the standard fedora-review template with some additions for Go packages. I still recommend running fedora-review on your packages and briefly checking its output (which I did myself here as well). Also, if you leave a comment containing the SPEC and SRPM URL boilerplate on the review bug each time you make a change, the bot will run fedora-review for you and attach a diff of your specfile changes since the last time it ran. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2431607 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202431607%23c11 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
