https://bugzilla.redhat.com/show_bug.cgi?id=2431607
Maxwell G <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|NEW |POST --- Comment #5 from Maxwell G <[email protected]> --- Package approved, but I noticed two other minor things to change before you import the package: > %files > %{_mandir}/man8/ipp-usb.8.* * Please change this to %{_mandir}/man8/ipp-usb.8* to match the format in https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages. > %{_sbindir}/ipp-usb * I would just reference %{_bindir} here and in %install now that /usr/sbin -> /usr/bin (https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin) Vendored Go Package Review ============== This package was generated using go2rpm and Go Vendor Tools, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The specfile is legible. - [x] The SRPM contains a valid `go-vendor-tools.toml`. - The default `detector = "askalono"` is included unless there is justification. - Manual license overrides are correct. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [x] There are no `%{_bindir}/*` wildcards in %files. - [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86. - [x] The package complies with the rest of the Golang and general Packaging Guidelines. Package approved! On import, don't forget to do the following: - [ ] Address the two nits above - [ ] Add the package to release-monitoring.org. - [ ] Give go-sig privileges (at least commit) on the package. - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket. Thanks! Source: <https://git.sr.ht/~gotmax23/fedora-scripts/tree/main/item/go-sig/vendored_review_template.md> -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2431607 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202431607%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
