https://bugzilla.redhat.com/show_bug.cgi?id=2423975



--- Comment #7 from Jerry James <[email protected]> ---
(In reply to Neal Gompa from comment #6)
> > VCS:            git:%{giturl}.git
> 
> Uhh, what is this? We have no specification for the VCS tag, so how is
> something supposed to figure this out?

I'm not sure what you mean.  The VCS tag is described here:
https://rpm.org/docs/6.0.x/manual/tags.html.  The part on the left of the first
colon is the command to run to checkout the upstream source code repository. 
The part on the right is the argument(s) to give to that command.

> (Also, wouldn't git+https make sense as the protocol?)

It isn't a protocol.  It's a command to run.

> Review notes:
> 
> * Package output follows Fedora Packaging Guidelines
> * Package builds and installs
> * Some directory ownership issues (dynamic subpackage definitions aren't
> pulling in Python as a runtime dep?)
>   - From fedora-review: Note: Directories without known owners:
> /usr/lib/python3.14, /usr/lib/python3.14/site-packages
> * Package licensing seems to be correct and valid
> 
> I'm not sure what we should do about the directory ownership issue...?

I've seen that on the last few python reviews I've done.  I'm not sure what
changed to make that warning start popping up, but I think it is spurious.  In
this case:
- python3-diagnostic Requires python(abi)
- python(abi) is Provided by the python3 package
- python3 Requires python3-libs
- python3-libs owns both /usr/lib/python3.14 and
/usr/lib/python3.14/site-packages

So there really is no directory ownership issue.  We should probably figure out
how to make fedora-review stop warning about it.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2423975

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202423975%23c7

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to