https://bugzilla.redhat.com/show_bug.cgi?id=2423975



--- Comment #6 from Neal Gompa <[email protected]> ---
Ooh, I'm excited to see something using declarative builds!

Spec review:

> VCS:            git:%{giturl}.git

Uhh, what is this? We have no specification for the VCS tag, so how is
something supposed to figure this out?

(Also, wouldn't git+https make sense as the protocol?)

Review notes:

* Package output follows Fedora Packaging Guidelines
* Package builds and installs
* Some directory ownership issues (dynamic subpackage definitions aren't
pulling in Python as a runtime dep?)
  - From fedora-review: Note: Directories without known owners:
/usr/lib/python3.14, /usr/lib/python3.14/site-packages
* Package licensing seems to be correct and valid

I'm not sure what we should do about the directory ownership issue...?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2423975

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202423975%23c6

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to