https://bugzilla.redhat.com/show_bug.cgi?id=2416808



--- Comment #3 from Neal Gompa <[email protected]> ---
(In reply to Terje Rosten from comment #2)
> Summary:
> -------
>  - Add gcc to buildreq?

Added gcc-c++

>  - run  desktop-file-validate on 
> /usr/share/applications/kcm_plasmalogin.desktop ?

Added %check for this.

>  - Unsure what rpmlint means by this_
>    systemd_user_post is invoked in %post and systemd_user_preun in %preun
>    for Systemd user units service files.
>    Note: Systemd user unit service file(s) in plasma-login-manager
>    See: https://docs.fedoraproject.org/en-US/packaging-
>    guidelines/Scriptlets/#_user_units

Fixed.

>  - fix license information

Fixed.

>  - ping upstream about invalid FSF address?

This is FSFE REUSE data error. I'll ask if anyone has talked to them about
this.

>  - comment on this issue:
>    plasma-login-manager.x86_64: E: executable-marked-as-config-file
> /etc/plasmalogin/Xsetup
>    plasma-login-manager.x86_64: E: executable-marked-as-config-file
> /etc/plasmalogin/Xstop
>    plasma-login-manager.x86_64: E: executable-marked-as-config-file
> /etc/plasmalogin/wayland-session

These are scripts that can be user modified. This is an X11 holdover sadly. :(

I've updated the packaging in place.

[fedora-review-service-build]


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2416808

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202416808%23c3

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to