https://bugzilla.redhat.com/show_bug.cgi?id=2416808
Terje Rosten <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |[email protected] Status|NEW |ASSIGNED Assignee|[email protected] |[email protected] --- Comment #2 from Terje Rosten <[email protected]> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Please improve license information, see e.g. LICENSES/ in source tarball. [-]: License file installed when any subpackage combination is installed. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/qt6/plugins/plasma, /usr/lib64/qt6/plugins/plasma/kcms, /usr/lib64/qt6/plugins/plasma/kcms/systemsettings [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dbus-1/system.d, /usr/lib64/qt6/plugins/plasma/kcms/systemsettings, /usr/lib64/qt6, /usr/share/polkit-1, /usr/lib64/qt6/plugins/plasma, /usr/lib64/qt6/plugins/plasma/kcms, /usr/share/dbus-1, /usr/libexec/kf6/kauth, /etc/pam.d, /usr/lib64/qt6/plugins, /usr/share/dbus-1/system-services, /usr/share/polkit-1/actions Seems to be a common problem for plasma/qt6 apps? Many core dirs are not owned? [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in plasma-login-manager [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2051 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kcm- plasmalogin [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: plasma-login-manager-0.21.0~git20251117.7dc6f4a-1.fc44.x86_64.rpm kcm-plasmalogin-0.21.0~git20251117.7dc6f4a-1.fc44.x86_64.rpm plasma-login-manager-0.21.0~git20251117.7dc6f4a-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4ol26a8u')] checks: 32, packages: 3 plasma-login-manager.src: E: spelling-error ('frontend', '%description -l en_US frontend -> fronted, front end, front-end') plasma-login-manager.x86_64: E: spelling-error ('frontend', '%description -l en_US frontend -> fronted, front end, front-end') plasma-login-manager.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/plasmalogin.conf plasma-login-manager.x86_64: W: non-standard-uid /var/lib/plasmalogin plasmalogin plasma-login-manager.x86_64: W: non-standard-gid /run/plasmalogin plasmalogin plasma-login-manager.x86_64: W: non-standard-gid /var/lib/plasmalogin plasmalogin plasma-login-manager.x86_64: E: non-standard-dir-perm /run/plasmalogin 711 plasma-login-manager.x86_64: E: non-standard-dir-perm /var/lib/plasmalogin 1770 plasma-login-manager.x86_64: W: no-manual-page-for-binary plasma-login-wallpaper plasma-login-manager.x86_64: W: no-manual-page-for-binary plasmalogin plasma-login-manager.x86_64: W: no-manual-page-for-binary startplasma-login-wayland kcm-plasmalogin.x86_64: W: no-documentation plasma-login-manager.spec: W: no-%check-section plasma-login-manager.spec:23: W: macro-in-comment %pre plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/GPL-2.0-only.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/GPL-2.0-or-later.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LGPL-2.0-or-later.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LGPL-2.1-or-later.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LICENSE plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LICENSES/GPL-2.0-only.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LICENSES/GPL-2.0-or-later.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LICENSES/LGPL-2.0-or-later.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LICENSES/LGPL-2.1-or-later.txt plasma-login-manager.x86_64: E: files-duplicated-waste 146280 plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/BSD-3-Clause.txt /usr/share/licenses/plasma-login-manager/BSD-3-Clause.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/CC0-1.0.txt /usr/share/licenses/plasma-login-manager/CC0-1.0.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/GPL-2.0-or-later.txt /usr/share/licenses/plasma-login-manager/GPL-2.0-only.txt:/usr/share/licenses/plasma-login-manager/GPL-2.0-or-later.txt:/usr/share/licenses/plasma-login-manager/LICENSES/GPL-2.0-only.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/GPL-3.0-only.txt /usr/share/licenses/plasma-login-manager/GPL-3.0-only.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/LGPL-2.0-or-later.txt /usr/share/licenses/plasma-login-manager/LGPL-2.0-or-later.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/LGPL-2.1-or-later.txt /usr/share/licenses/plasma-login-manager/LGPL-2.1-or-later.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LicenseRef-KDE-Accepted-GPL.txt /usr/share/licenses/plasma-login-manager/LICENSES/LicenseRef-KDE-Accepted-GPL.txt plasma-login-manager.x86_64: E: executable-marked-as-config-file /etc/plasmalogin/Xsetup plasma-login-manager.x86_64: E: executable-marked-as-config-file /etc/plasmalogin/Xstop plasma-login-manager.x86_64: E: executable-marked-as-config-file /etc/plasmalogin/wayland-session plasma-login-manager.x86_64: W: empty-%pre plasma-login-manager.x86_64: W: empty-%postun kcm-plasmalogin.x86_64: W: desktopfile-without-binary /usr/share/applications/kcm_plasmalogin.desktop systemsettings 3 packages and 0 specfiles checked; 17 errors, 20 warnings, 12 filtered, 17 badness; has taken 0.5 s Rpmlint (debuginfo) ------------------- Checking: plasma-login-manager-debuginfo-0.21.0~git20251117.7dc6f4a-1.fc44.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpp95o9e2p')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 20 filtered, 0 badness; has taken 0.7 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 plasma-login-manager.x86_64: W: unused-direct-shlib-dependency /usr/bin/plasmalogin /lib64/libXau.so.6 plasma-login-manager.x86_64: W: unused-direct-shlib-dependency /usr/libexec/plasmalogin-helper /lib64/libXau.so.6 plasma-login-manager.x86_64: E: spelling-error ('frontend', '%description -l en_US frontend -> fronted, front end, front-end') plasma-login-manager.x86_64: W: post-without-tmpfile-creation /usr/lib/tmpfiles.d/plasmalogin.conf plasma-login-manager.x86_64: W: non-standard-uid /var/lib/plasmalogin plasmalogin plasma-login-manager.x86_64: W: non-standard-gid /run/plasmalogin plasmalogin plasma-login-manager.x86_64: W: non-standard-gid /var/lib/plasmalogin plasmalogin plasma-login-manager.x86_64: E: non-standard-dir-perm /run/plasmalogin 711 plasma-login-manager.x86_64: E: non-standard-dir-perm /var/lib/plasmalogin 1770 plasma-login-manager.x86_64: W: no-manual-page-for-binary plasma-login-wallpaper plasma-login-manager.x86_64: W: no-manual-page-for-binary plasmalogin plasma-login-manager.x86_64: W: no-manual-page-for-binary startplasma-login-wayland kcm-plasmalogin.x86_64: W: no-documentation plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/GPL-2.0-only.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/GPL-2.0-or-later.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LGPL-2.0-or-later.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LGPL-2.1-or-later.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LICENSE plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LICENSES/GPL-2.0-only.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LICENSES/GPL-2.0-or-later.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LICENSES/LGPL-2.0-or-later.txt plasma-login-manager.x86_64: E: incorrect-fsf-address /usr/share/licenses/plasma-login-manager/LICENSES/LGPL-2.1-or-later.txt plasma-login-manager.x86_64: E: files-duplicated-waste 146280 plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/BSD-3-Clause.txt /usr/share/licenses/plasma-login-manager/BSD-3-Clause.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/CC0-1.0.txt /usr/share/licenses/plasma-login-manager/CC0-1.0.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/GPL-2.0-or-later.txt /usr/share/licenses/plasma-login-manager/GPL-2.0-only.txt:/usr/share/licenses/plasma-login-manager/GPL-2.0-or-later.txt:/usr/share/licenses/plasma-login-manager/LICENSES/GPL-2.0-only.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/GPL-3.0-only.txt /usr/share/licenses/plasma-login-manager/GPL-3.0-only.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/LGPL-2.0-or-later.txt /usr/share/licenses/plasma-login-manager/LGPL-2.0-or-later.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LICENSES/LGPL-2.1-or-later.txt /usr/share/licenses/plasma-login-manager/LGPL-2.1-or-later.txt plasma-login-manager.x86_64: W: files-duplicate /usr/share/licenses/plasma-login-manager/LicenseRef-KDE-Accepted-GPL.txt /usr/share/licenses/plasma-login-manager/LICENSES/LicenseRef-KDE-Accepted-GPL.txt plasma-login-manager.x86_64: E: executable-marked-as-config-file /etc/plasmalogin/Xsetup plasma-login-manager.x86_64: E: executable-marked-as-config-file /etc/plasmalogin/Xstop plasma-login-manager.x86_64: E: executable-marked-as-config-file /etc/plasmalogin/wayland-session plasma-login-manager.x86_64: W: empty-%pre plasma-login-manager.x86_64: W: empty-%postun kcm-plasmalogin.x86_64: W: desktopfile-without-binary /usr/share/applications/kcm_plasmalogin.desktop systemsettings 3 packages and 0 specfiles checked; 16 errors, 20 warnings, 34 filtered, 16 badness; has taken 0.9 s Unversioned so-files -------------------- kcm-plasmalogin: /usr/lib64/qt6/plugins/plasma/kcms/systemsettings/kcm_plasmalogin.so Source checksums ---------------- https://invent.kde.org/plasma/plasma-login-manager/-/archive/7dc6f4afee1dfb765a2c57aab43969c64e04a504/plasma-login-manager-7dc6f4a.tar.gz : CHECKSUM(SHA256) this package : abc79cf4cb3653ea32d24fa49e2bde063e4a8269e74d08db0934fc345f64336e CHECKSUM(SHA256) upstream package : abc79cf4cb3653ea32d24fa49e2bde063e4a8269e74d08db0934fc345f64336e Requires -------- plasma-login-manager (rpmlib, GLIBC filtered): (kcm-plasmalogin(x86-64) if plasma-systemsettings(x86-64)) /bin/sh /usr/bin/sh config(plasma-login-manager) group(plasmalogin) kf6-filesystem kf6-kimageformats(x86-64) kwin-wayland(x86-64) libKF6ConfigCore.so.6()(64bit) libKF6ConfigGui.so.6()(64bit) libKF6ConfigQml.so.6()(64bit) libKF6CoreAddons.so.6()(64bit) libKF6DBusAddons.so.6()(64bit) libKF6I18n.so.6()(64bit) libKF6Package.so.6()(64bit) libKF6WindowSystem.so.6()(64bit) libLayerShellQtInterface.so.6()(64bit) libPlasmaQuick.so.6()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.10)(64bit) libQt6DBus.so.6()(64bit) libQt6DBus.so.6(Qt_6)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Network.so.6()(64bit) libQt6Network.so.6(Qt_6)(64bit) libQt6Qml.so.6()(64bit) libQt6Qml.so.6(Qt_6)(64bit) libQt6Qml.so.6(Qt_6.10_PRIVATE_API)(64bit) libQt6Quick.so.6()(64bit) libQt6Quick.so.6(Qt_6)(64bit) libXau.so.6()(64bit) libc.so.6()(64bit) libkworkspace6.so.6()(64bit) libpam.so.0()(64bit) libpam.so.0(LIBPAM_1.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) rtld(GNU_HASH) shadow-utils systemd user(plasmalogin) xorg-x11-xinit kcm-plasmalogin (rpmlib, GLIBC filtered): libKF6AuthCore.so.6()(64bit) libKF6ConfigCore.so.6()(64bit) libKF6ConfigGui.so.6()(64bit) libKF6ConfigQml.so.6()(64bit) libKF6CoreAddons.so.6()(64bit) libKF6I18n.so.6()(64bit) libKF6KCMUtilsCore.so.6()(64bit) libKF6KCMUtilsQuick.so.6()(64bit) libKF6KIOGui.so.6()(64bit) libKF6Package.so.6()(64bit) libKF6Service.so.6()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.10)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Qml.so.6()(64bit) libQt6Qml.so.6(Qt_6)(64bit) libQt6Quick.so.6()(64bit) libQt6Quick.so.6(Qt_6)(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) plasma-login-manager rtld(GNU_HASH) Provides -------- plasma-login-manager: config(plasma-login-manager) group(plasmalogin) plasma-login-manager plasma-login-manager(x86-64) service(graphical-login) user(plasmalogin) kcm-plasmalogin: application() application(kcm_plasmalogin.desktop) kcm-plasmalogin kcm-plasmalogin(x86-64) Summary: ------- - Add gcc to buildreq? - run desktop-file-validate on /usr/share/applications/kcm_plasmalogin.desktop ? - Unsure what rpmlint means by this_ systemd_user_post is invoked in %post and systemd_user_preun in %preun for Systemd user units service files. Note: Systemd user unit service file(s) in plasma-login-manager See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Scriptlets/#_user_units - fix license information - ping upstream about invalid FSF address? - comment on this issue: plasma-login-manager.x86_64: E: executable-marked-as-config-file /etc/plasmalogin/Xsetup plasma-login-manager.x86_64: E: executable-marked-as-config-file /etc/plasmalogin/Xstop plasma-login-manager.x86_64: E: executable-marked-as-config-file /etc/plasmalogin/wayland-session -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2416808 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202416808%23c2 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
