https://bugzilla.redhat.com/show_bug.cgi?id=2415364
--- Comment #6 from Fabio Valentini <[email protected]> --- I don't think I have much to add to what Ben has already said here. Just some general comments: 1. It appears that the "new_cargo_macros" macro you define at the top of the spec file is unused. And I'm not sure what its purpose would even be? 2. The Summary and %description are not properly formatted - the Summary should be <80 characters long (so ... use something more concise than the current one) and the %description should be line-wrapped to <=72 characters per line. Maybe: "Summary: Extensible AI agent that goes beyond code suggestions" The fact that it's open source is a requirement for packaging for Fedora, you don't need to repeat that :) 3. It appears that you're using a tarball that contains "patched" sources, not the upstream ones. That's not how packaging is supposed to work - you should point the package at the upstream project's sources, and apply any patches you need to apply in packaging. ~~~ Also note that it *is* allowed to build with vendored Rust dependencies for Fedora - if packaging all missing dependencies would place an unreasonable burden on the packager. In this case, it looks like you have (at first glance) ~20 new dependencies that are not yet packaged for Fedora, which I would place to the more "unreasonable" end of that spectrum. However, it would be great to check *first* if you could actually trim that dependency tree to something more reasonable - for example, as Ben mentioned, by dropping Windows-specific, benchmarking-specific dependencies, or dependencies that are only needed for compiling example code. Another possibility is to check whether you some dependencies are pulled in by features that you don't even want or need, and to disable them too. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2415364 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202415364%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
