https://bugzilla.redhat.com/show_bug.cgi?id=2394931



--- Comment #35 from Benson Muite <[email protected]> ---
Thanks for the updates.  A couple more fixes:
a) No distinfo directory is created by the python package.
This is needed:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dist_info_metadata

By using pyproject.toml, one can generate the metadata:
https://github.com/randombit/botan/pull/5040
https://copr.fedorainfracloud.org/coprs/build/9760605
https://koji.fedoraproject.org/koji/taskinfo?taskID=138694911

Also allows one to remove:
# Remove shebang
sed -e '1{/^#!/d}' -i %{buildroot}%{python3_sitearch}/botan%{major_version}.py
# If installs python module in sitearch, move it to sitelib. The py package is
noarch, loading the lib dynamically.
%if "%{python3_sitelib}" != "%{python3_sitearch}"
mkdir -p %{buildroot}%{python3_sitelib}
mv %{buildroot}%{python3_sitearch}/botan%{major_version}.py
%{buildroot}%{python3_sitelib}/botan%{major_version}.py
%endif

May also want to comment on:
https://github.com/randombit/botan/pull/5040
if you see a need for futher changes.

b) Please add a link to the pull request for the install-fix.patch


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2394931

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202394931%23c35

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to