https://bugzilla.redhat.com/show_bug.cgi?id=2397149
--- Comment #3 from Benson Muite <[email protected]> --- Thanks for the feedback. > - It looks like you are skipping the same test twice: > > k="${k-}${k+ and }not (Test_Locale and > test_fromstring_numbers_locale_insensitive)" > k="${k-}${k+ and }not (Test_Locale and > test_fromstring_numbers_locale_insensitive)" > > This is harmless but redundant. Removed extra line > - Normally, every invocation of install should have -p. The installation of > the > docbook file lacks this; I’m not blocking the review on it because the > timestamp of junitparser.xml is just the build time and is going to be > clamped to SOURCE_DATE_EPOCH no matter what, so it really doesn’t matter in > this case. Fixed. > - Consider packaging README.rst and CHANGELOG.md as documentation. Done > - I think that %doc should be added to these: > > %dir %{_datadir}/help/en > %lang(en) %{_datadir}/help/en/python-junitparser Done Updated: spec: https://fed500.fedorapeople.org/python-junitparser.spec srpm: https://fed500.fedorapeople.org/python-junitparser-4.0.2-1.fc42.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2397149 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202397149%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
