https://bugzilla.redhat.com/show_bug.cgi?id=2397149
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #6 from Ben Beasley <[email protected]> --- The spec-file diff shows that all issues found in the previous review were fixed: --- ../../srpm-unpacked/python-junitparser.spec 2025-09-21 01:00:00.000000000 +0100 +++ srpm-unpacked/python-junitparser.spec 2025-10-01 01:00:00.000000000 +0100 @@ -53,7 +53,6 @@ sphinx-build -b texinfo . texinfo pushd texinfo makeinfo --docbook junitparser.texi -ls popd popd @@ -62,20 +61,21 @@ %pyproject_install %pyproject_save_files -l junitparser mkdir -p %{buildroot}%{_datadir}/help/en/python-junitparser -install -m644 docs/texinfo/junitparser.xml \ +install -p -m644 docs/texinfo/junitparser.xml \ %{buildroot}%{_datadir}/help/en/python-junitparser %check %pyproject_check_import # Tests require different console locale settings k="${k-}${k+ and }not (Test_Locale and test_fromstring_numbers_locale_insensitive)" -k="${k-}${k+ and }not (Test_Locale and test_fromstring_numbers_locale_insensitive)" %pytest -k "${k-}" %files -n python3-junitparser -f %{pyproject_files} %{_bindir}/junitparser -%dir %{_datadir}/help/en -%lang(en) %{_datadir}/help/en/python-junitparser +%doc README.rst +%doc CHANGELOG.md +%doc %dir %{_datadir}/help/en +%doc %lang(en) %{_datadir}/help/en/python-junitparser %changelog %autochangelog The output of fedora-review did not indicate any new issues, and neither did rpmlint: Rpmlint ------- Checking: python3-junitparser-4.0.2-1.fc44.noarch.rpm python-junitparser-4.0.2-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8kzpm1pr')] checks: 32, packages: 2 python-junitparser.src: E: spelling-error ('xUnit', 'Summary(en_US) xUnit -> x Unit, unit') python-junitparser.src: E: spelling-error ('xUnit', '%description -l en_US xUnit -> x Unit, unit') python-junitparser.src: E: spelling-error ('lxml', '%description -l en_US lxml -> XML') python3-junitparser.noarch: E: spelling-error ('xUnit', 'Summary(en_US) xUnit -> x Unit, unit') python3-junitparser.noarch: E: spelling-error ('xUnit', '%description -l en_US xUnit -> x Unit, unit') python3-junitparser.noarch: E: spelling-error ('lxml', '%description -l en_US lxml -> XML') python3-junitparser.noarch: W: no-manual-page-for-binary junitparser 2 packages and 0 specfiles checked; 6 errors, 1 warnings, 7 filtered, 6 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-junitparser.noarch: E: spelling-error ('xUnit', 'Summary(en_US) xUnit -> x Unit, unit') python3-junitparser.noarch: E: spelling-error ('xUnit', '%description -l en_US xUnit -> x Unit, unit') python3-junitparser.noarch: E: spelling-error ('lxml', '%description -l en_US lxml -> XML') python3-junitparser.noarch: W: no-manual-page-for-binary junitparser 1 packages and 0 specfiles checked; 3 errors, 1 warnings, 3 filtered, 3 badness; has taken 0.0 s The package is therefore APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2397149 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202397149%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
