https://bugzilla.redhat.com/show_bug.cgi?id=2379721
Neal Gompa <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #20 from Neal Gompa <[email protected]> --- Spec review notes: > Provides: bundled(MysticCards) > Provides: bundled(DemonicLetters) This should be bundled(fonts(<fontname>)), since these fonts are in TTF/OTF form. > %patch 0 -p1 > %patch 1 -p1 This can be replaced with "%autopatch -p1". > %build > # Now, we build OpenMW. > %cmake -G Ninja \ > -DBUILD_OPENMW_TESTS:BOOL=ON \ > -DBULLET_STATIC:BOOL=ON \ > -DFETCHCONTENT_FULLY_DISCONNECTED:BOOL=ON \ > -DFETCHCONTENT_SOURCE_DIR_BULLET:PATH=%{_builddir}/bullet \ > -DFETCHCONTENT_SOURCE_DIR_OSG:PATH:PATH=%{_builddir}/osg \ > > -DFETCHCONTENT_SOURCE_DIR_RECASTNAVIGATION:PATH=%{_builddir}/recastnavigation > \ > -DGLOBAL_DATA_PATH:PATH=%{_datadir} \ > -DOPENMW_USE_SYSTEM_BULLET:BOOL=OFF \ > -DOPENMW_USE_SYSTEM_GOOGLETEST:BOOL=ON \ > -DOPENMW_USE_SYSTEM_OSG:BOOL=OFF \ > -DOSG_STATIC:BOOL=ON Unless you plan to ship this in EPEL 8/9, it would be good to move the %cmake invocation to the %conf section. Cf. https://rpm-software-management.github.io/rpm/manual/spec.html#conf-since-rpm--418 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2379721 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202379721%23c20 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
