Yujun and Fatih,
Let’s use “silent-start” option for gerrit trigger plugin [1]. I checked gerrit plugin for Jenkins [2,3], but I cannot find how we can make jenkins not to reset verified status by another solution, although ‘silent-start’ won’t put the link to triggered jenkins job. I posted my proposal [4]. [1] http://docs.openstack.org/infra/jenkins-job-builder/triggers.html?highlight=triggers#triggers.gerrit [2] https://github.com/jenkinsci/gerrit-trigger-plugin/blob/master/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/ParameterExpander.java#L150-L194 [3] https://github.com/jenkinsci/gerrit-trigger-plugin/blob/master/src/main/java/com/sonyericsson/hudson/plugins/gerrit/trigger/gerritnotifier/NotificationFactory.java#L199 [4] https://gerrit.opnfv.org/gerrit/26811 BR, Ryota From: opnfv-tech-discuss-boun...@lists.opnfv.org [mailto:opnfv-tech-discuss-boun...@lists.opnfv.org] On Behalf Of Yujun Zhang Sent: Saturday, January 07, 2017 10:38 PM To: Fatih Degirmenci <fatih.degirme...@ericsson.com>; TECH-DISCUSS OPNFV <opnfv-tech-discuss@lists.opnfv.org> Subject: Re: [opnfv-tech-discuss] [infra][doctor] experimental trigger not working Hi, Fatih It seems the experimental check will clear verified status which is an unexpected side-effect. [Screen Shot 2017-01-07 at 9.35.49 PM.png] × On Sat, Jan 7, 2017 at 6:18 PM Fatih Degirmenci <fatih.degirme...@ericsson.com<mailto:fatih.degirme...@ericsson.com>> wrote: Hi Yujun, The issues are fixed now and the job gets triggered correctly by the keyword check-experimental. If the values are not passed to the macros, they will not be updated by jjb and stay as they are - {project} and {branch}. We verify jjb updates using jjb but this type of errors are not caught by it. /Fatih From: Yujun Zhang <zhangyujun+...@gmail.com<mailto:zhangyujun%2b...@gmail.com>> Date: Friday, 6 January 2017 at 12:46 To: Fatih Degirmenci <fatih.degirme...@ericsson.com<mailto:fatih.degirme...@ericsson.com>>, "opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org>" <opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org>> Subject: Re: [opnfv-tech-discuss] [infra][doctor] experimental trigger not working Thanks Fatih Fix proposed in https://gerrit.opnfv.org/gerrit/#/c/26767/ What will the value of '{project}' be if we forget to pass a variable to the macro? Is it possible to detect such error with a verification job? On Fri, Jan 6, 2017 at 7:15 PM Fatih Degirmenci <fatih.degirme...@ericsson.com<mailto:fatih.degirme...@ericsson.com>> wrote: Hi Yujun, This is due to not passing project and branch values to macro. This causes the use of incorrect values for PROJECT and GERRIT_PROJECT parameters in the created Jenkins job. (job has {project} as PROJECT value and {branch} as GERRIT_PROJECT value as oppose to doctor and master respectively.) You either need to pass those values triggers: - 'doctor-experimental': project: '{project}' branch: '{branch}' or move trigger into job body rather than using macro. /Fatih From: <opnfv-tech-discuss-boun...@lists.opnfv.org<mailto:opnfv-tech-discuss-boun...@lists.opnfv.org>> on behalf of Yujun Zhang <zhangyujun+...@gmail.com<mailto:zhangyujun%2b...@gmail.com>> Date: Friday, 6 January 2017 at 08:02 To: "opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org>" <opnfv-tech-discuss@lists.opnfv.org<mailto:opnfv-tech-discuss@lists.opnfv.org>> Subject: [opnfv-tech-discuss] [infra][doctor] experimental trigger not working Hi, infra experts We want to introduce a jenkins job trigger for experimental changes[1] A trigger is created for doctor project[2], but it seems not working as expected. When a new comment "check experimental" is added[3], no job is triggered[4] as expected. Could anyone give some hint on how to debug such issue? The trigger is defined as a macro and referenced in doctor-profiling-master job - trigger: name: 'doctor-experimental' triggers: - gerrit: server-name: 'gerrit.opnfv.org<http://gerrit.opnfv.org>' trigger-on: - comment-added-contains-event: comment-contains-value: 'check experimental' - job-template: name: 'doctor-profiling-{stream}' ... triggers: - 'doctor-experimental' [1]: http://docs.openstack.org/infra/system-config/test-infra- requirements.html#experimental<http://docs.openstack.org/infra/system-config/test-infra-requirements.html#experimental> [2]:https://gerrit.opnfv.org/gerrit/#/c/26439/ [3]: https://gerrit.opnfv.org/gerrit/#/c/26531/ [4]: https://build.opnfv.org/ci/view/doctor/job/doctor-profiling-master/
_______________________________________________ opnfv-tech-discuss mailing list opnfv-tech-discuss@lists.opnfv.org https://lists.opnfv.org/mailman/listinfo/opnfv-tech-discuss
